Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Double Slash
https://nginx.org/en/docs/http/ngx_http_core_module.html#merge_slashes
Internally is handles the double slashes, but does not always match properly when working with query strings. I am not finding the original document that talked about the query strings not always matching. However is apparent with URLs like the one below.
Then you have items like below that work as expected with double slashes
https://superuser.com/questions/565250/how-to-remove-double-slash-in-urls-served-by-nginx
The above code with
merge_slashes
on will redirect to the proper URL. This will redirect with query strings. It redirects properly since the URL internally has all of the slashes combined internally.Manual Tests
https://host.docker.internal/Test_Request_Portal/admin//?a=mod_templates&file=view_homepage.tpl
will redirect tohttps://host.docker.internal/Test_Request_Portal/admin/a=mod_templates&file=view_homepage.tpl
https://host.docker.internal/Test_Request_Portal/report.php?a=LEAF_import_data
will redirect tohttps://host.docker.internal/Test_Request_Portal/report.phpa=LEAF_import_data
Test
Now that we have VAPO merged on this corrected this test
API
E2E